I think Iāve finished account and base-system.
But Iām not sure if I made the Pull-request the right way.
Can you please check that?
Second Question:
is ist allowed (and sensefull) to change :note: or : warning : into
german expressions or are they keywords that mustnāt be changed?
Note and warning are tag, AFAIK they work only in English
1 Like
giacomo
(Giacomo Sanchietti)
March 16, 2016, 8:09am
23
I donāt see any pull request
Take a look at this: About pull requests - GitHub Docs
It seems ok to me, when you want to merge, open a pull request and I will configure the build process by adding the german language!
And now?
There was al button at the end āclose pullrequestā ā¦ shell I push it?
For now im in a hurry - check mail later ā¦
giacomo
(Giacomo Sanchietti)
March 16, 2016, 8:35am
25
Just wait until someone check the pull request: I just saw it but I need a little time to check it.
You should push the close button only if you donāt want anymore to merge your pull request.
Yeah, we can see it gischupa!
I have not worked with github till now, but I think it is not really complex, is it?
Nope, very easy from the web interface. Check the links above and ask for help @Wolfgang_Hofer and @Hunv are already on the right track
Sorry got no email notification. Looks good.
Hunv
(Kristian Reukauff)
March 17, 2016, 7:27am
30
firewall.rst is done.
Will take everything left up to the letter F (including) next.
That means:
chat.rst
content_filter.rst
dhcp.rst
dns.rst
ftp.rst
3 Likes
How does working with GitHub look? Is it so tricky?
Hunv
(Kristian Reukauff)
March 17, 2016, 12:51pm
32
Maybe. I have not done the complete chain of things, but what I did so far:
Register/Login at Github
Open the nethserver-docs-Project
Click on āforkā at the top right => this will create a ācopyā of the project on your on useraccount
Change everything you like to change
(I havenāt done this) When everything is done, choose the āpull requestā-option when adding/changing files
1 Like
Very good! We need to write down an HowTo basing on these notes and adding it to this section:
http://wiki.nethserver.org/doku.php?id=howto:volunteering#translations
/cc @jgjimenezs
1 Like
giacomo
(Giacomo Sanchietti)
March 17, 2016, 4:54pm
34
1 Like
Hunv
(Kristian Reukauff)
March 18, 2016, 8:26pm
35
Created Pull-Request with files I translated so far. Iām on vacation next week, so there will be no updates next week.
3 Likes
Hunv
(Kristian Reukauff)
March 18, 2016, 9:37pm
37
Baltic Sea. Not far away, but for getting off of daily business it is enough
2 Likes
giacomo
(Giacomo Sanchietti)
March 23, 2016, 4:38pm
38
@Hunv can you please fix the pull request?
Hunv
(Kristian Reukauff)
March 23, 2016, 5:27pm
39
Yes, next week when I am back from vacation.
2 Likes
Hunv
(Kristian Reukauff)
March 27, 2016, 7:28am
40
Soā¦ back from vacation.
I removed the conflicted file from the pull request:
1 Like