Error with container image name starting with a number

oneitonitram · March 9, 2024, 1:25pm

Now here is the interesting bit, especially pertaining to below

the docker reference source for this app is as defined here

    --label="org.nethserver.images=docker.io/2fauth/2fauth:${app_version}" \

Inside the app container service file we are supposed to define as such

   ${2FAUTH_IMAGE}

since we can not begin with the name, is there another way, we can re-define it and have it implemented within the context of the app?

maybe @stephdl and @davidep would be kind enough to help with this conundrum.

and i believe solving this problem, would enable me solve another similar challenge i have experiences in another app as well.

oneitonitram · March 10, 2024, 7:23pm

NS8-App Mayhem: A Modules Dev thread on multiple modules issues faced

could someone help me figure out why i am getting the following error here

2024-03-08T23:29:05+03:00 [1:2fauth2:systemd] 2fauth-app.service: Ignoring invalid environment assignment '2FAUTH_IMAGE=docker.io/2fauth/2fauth:5.0.4': /home/2fauth2/.config/state/environment
2024-03-08T23:29:05+03:00 [1:2fauth2:systemd] 2fauth.service: Ignoring invalid environment assignment '2FAUTH_IMAGE=docker.io/2fauth/2fauth:5.0.4': /home/2fauth2/.config/state/environment
2024-03-08T23:29:05+03:00 [1:2fauth2:systemd] Stopping Podman 2fauth.service...
2024-03-08T23:29:05+03:00 [1:2fauth2:systemd] 2fauth.service: Ignoring invalid environment assignment '2FAUTH_IMAGE=docker.io/2fauth/2fauth:5.0.4': /home/2fauth2/.config/state/environment

In relation to this App geniusdynamics/ns8-2fa: NS8 App for 2FAuth https://docs.2fauth.app/ (github.com)

is it that its not permisible to have something like this

${2FAUTH_IMAGE}

@stephdl any ideas?

stephdl · March 10, 2024, 7:57pm

github.com

geniusdynamics/ns8-2fa/blob/c4a86a89823e671c5d0559039f63b260272d8530/imageroot/systemd/user/2fauth-app.service#L59


      
              --env MIX_PUSHER_APP_KEY="${PUSHER_APP_KEY}" \
              --env MIX_PUSHER_APP_CLUSTER="${PUSHER_APP_CLUSTER}" \
              --env MIX_ENV=local
              --env MAIL_DRIVER=SMTP \
              --env MAIL_HOST=smtp.example.com \
              --env MAIL_PORT=587 # STARTTLS \
              --env MAIL_USERNAME=2fauth@example.com \
              --env MAIL_PASSWORD=password1234 \
              --env MAIL_FROM_NAME=2FAuth \
              --env MAIL_FROM_ADDRESS=2fauth@example.com \
              ${AUTH_IMAGE}
          ExecStop=/usr/bin/podman stop --ignore --cidfile %t/2fauth-app.ctr-id -t 10
          ExecReload=/usr/bin/podman kill -s HUP 2fauth-app
          SyslogIdentifier=%u
          ExecStopPost=/usr/bin/podman rm --ignore -f --cidfile %t/2fauth-app.ctr-id
          PIDFile=%t/2fauth-app.pid
          Type=forking
          
          [Install]
          WantedBy=default.target

Your image name is not good should be 2FAUTH_IMAGE

dnutan · March 10, 2024, 9:18pm

is that an environment variable or it isn’t?

oneitonitram · March 11, 2024, 4:17am

that was my attempt to change it to somethign other than 2FAUTH_IMAGE

because the env begining with 2 is being rejected, and thus does nto work. any idea what should be done?

stephdl · March 11, 2024, 7:32am

https://www.google.com/search?q=systemd+Ignoring+invalid+environment+assignment&client=ms-android-samsung-ss&sca_esv=e9d0f02f0fc54781&sxsrf=ACQVn0_0ZuV2BQAv2Z8scdswyTcIB8drEA%3A1710142075802&ei=e7LuZYbDMJuekdUP5sSB2A0&udm=&oq=systemd+Ignoring+invalid+environment+assignment&gs_lp=EhNtb2JpbGUtZ3dzLXdpei1zZXJwIi9zeXN0ZW1kIElnbm9yaW5nIGludmFsaWQgZW52aXJvbm1lbnQgYXNzaWdubWVudDIIEAAYBxgeGBMyBhAAGB4YEzIIECEYoAEYwwQyCBAhGKABGMMEMggQIRigARjDBEi9PFD4KliFOHACeAGQAQCYAawBoAGGCKoBAzIuNrgBA8gBAPgBAZgCCKACzgbCAgoQABhHGNYEGLADwgIHECMYsAIYJ8ICCRAAGIAEGA0YE8ICChAAGAUYBxgeGBPCAgoQABgFGB4YDRgTwgIKEAAYCBgeGA0YE8ICBhAAGAcYHsICChAhGAoYoAEYwwSYAwCIBgGQBgKSBwMyLjagB5M_&sclient=mobile-gws-wiz-serp

stephdl · March 11, 2024, 7:33am

When you have started the service check the environment file you might have some surprise inside I suppose

Else I have no clue you need to dive with the google link I posted

oneitonitram · March 11, 2024, 6:26pm

thank you @davidep path me up once resolution is in sight.

EDIT: is there a card to track this issue?

davidep · March 20, 2024, 5:36pm

Here it is! NethServer 8 · GitHub

oneitonitram · May 28, 2024, 5:27pm

Hello @davidep How hard is it to solve this based on your assessment from your end, and would it be possible to kindly have this on schedule for me?

davidep · May 30, 2024, 8:29am

Well, we’re starting some works around the Software Center: I’d fix this issue by building the variable name with a letter prefix, for example in your case it would be I2FAUTH_IMAGE. Do you accept it as solution?

oneitonitram · May 30, 2024, 10:38am

Unless i build my own docker image to implement that kind of naming, all other options i have tired seemed to fail, since the original image has that given name, and referencing it in any way, would still break.

davidep · May 30, 2024, 11:58am

I know it is something out of your control and there’s no other choice than a fix on the core side.

oneitonitram · May 30, 2024, 12:06pm

ok, ill be expecting a core fix kindly.

Goten myself into a situation whereby i need a TOTP available on the web for multiple users…
and the alternative solution thats secure is abit more complex to implement on NS8.

oneitonitram · July 30, 2024, 8:29pm

hello @davidep were getting the following error

ignoring invalid environment assignment '2FAUTH_IMAGE=docker.io/2fauth/2fauth:5.1.0': /home/2fauth7/.config/state/environment

was this implemented?..

cc @kemboielvis22

davidep · August 2, 2024, 7:48am

Hi Martin,
no it wasn’t, it’s still in the TODO list hopefully I’ll work on it soon.

oneitonitram · August 2, 2024, 7:52am

Ok Noted, We have made a workaround on the same

github.com

geniusdynamics/ns8-2fauth/blob/82b0e37c820f04465ddb8bc1f1e1d706742501ad/imageroot/systemd/user/2fauth-app.service#L30


      
          ExecStartPre=/bin/bash -c 'if [ ! -f %S/state/database.sqlite ]; then /bin/touch %S/state/database.sqlite; fi'
          ExecStartPre=/bin/rm -f %t/2fauth-app.pid %t/2fauth-app.ctr-id
          ExecStartPre=-runagent discover-smarthost
          ExecStart=/usr/bin/podman run --conmon-pidfile %t/2fauth-app.pid \
              --cidfile %t/2fauth-app.ctr-id --cgroups=no-conmon \
              --pod-id-file %t/2fauth.pod-id --replace -d --name  2fauth-app \
              --volume 2fauth-app:/var/www/html/:Z \
              --volume 2fauth-config:/tmp:Z \
              --env-file=%S/state/key.env \
              --env-file=%S/state/app.env \
              docker.io/2fauth/2fauth:5.2.0
          ExecStop=/usr/bin/podman stop --ignore --cidfile %t/2fauth-app.ctr-id -t 10
          ExecReload=/usr/bin/podman kill -s HUP 2fauth-app
          SyslogIdentifier=%u
          ExecStopPost=/usr/bin/podman rm --ignore -f --cidfile %t/2fauth-app.ctr-id
          PIDFile=%t/2fauth-app.pid
          Type=forking
          
          [Install]
          WantedBy=default.target

Seems to work so far, however we would prefer the correct way, to maintain standards

pike · August 2, 2024, 11:35am

Question is: how to sort containers without renaming and without… using numbers as starting characters?

oneitonitram · August 2, 2024, 11:48am

Am not sure about that, but the method shown above seems to work, though i have noticed a weired error that arises from the application, if you click on clear cache from the application, it crashes… i assume due to the container being loaded suring configure as opposed to during build

davidep · August 5, 2024, 6:25am

A post was split to a new topic: Run scripts in Systemd