Error with container image name starting with a number

Finally filed a bug here!

Thanks @oneitonitram

You can check if the fix works by installing NS8 for scratch with this command:

bash install.sh ghcr.io/nethserver/core:bug-6990

You’ve to test it with the old 2fauth module release. Look at the bug description for the command I used to reproduce the bug.

You also need to change file 2fauth-app.service to use the variable ${I2FAUTH_IMAGE}, instead of ${2FAUTH_IMAGE} which is not allowed in environment files. Note the I prepended to avoid starting the var name with a digit.

Won’t doing this change the reference image. Or does it mean for any other images in future starting with a leading number, we should append the “I” to the name of image first?

General rules want the environment variable begins with alphabetical characters. Image name rules on the contrary, allow a starting digit. The fix works around these conflicting naming rules by adding a I prefix, if the image name starts with a digit.

I added a commit to my PR, to document the change. Read the resulting doc section here: ns8-core/docs/modules/images.md at b1d71acdb2f1ac08023f9084a34021b969525f29 · NethServer/ns8-core · GitHub

This is a patch excerpt, maybe more clear than many words:

Sorry, I forgot the answer.

Yes, you should prepend the I in this case: 2fauth becomes I2FAUTH_IMAGE, as written in the docs now.

1 Like

Fixed in Release 2.9.2 · NethServer/ns8-core · GitHub

1 Like

Thank you for the Update. Let us update the Application in question on our github repo

Update: New version of the App has been released.
Release 1.0.0-beta.1 · geniusdynamics/ns8-2fauth (github.com)

1 Like

This topic was automatically closed after 10 days. New replies are no longer allowed.