Why cockpit is not restarted

stephdl · February 29, 2020, 9:53am

I was always wondering why nethserver-cockpit-update doesn’t restart the cockpit service, I think we could have an issue here and probably with all cockpit modules we have

github.com

NethServer/nethserver-cockpit/blob/master/createlinks

#!/usr/bin/perl
#
# Copyright (C) 2017 Nethesis S.r.l.
# http://www.nethesis.it - nethserver@nethesis.it
#
# This script is part of NethServer.
#
# NethServer is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License,
# or any later version.
#
# NethServer is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with NethServer.  If not, see COPYING.
#

This file has been truncated. show original

cc @dev_team

davidep · February 29, 2020, 12:05pm

cockpit-ws doesn’t need restart because it is started on demand by systemd socket activation and it is stopped after 30secs the last user session ends.

stephdl · February 29, 2020, 12:29pm

ok but what it could occur if

you have the UI displayed on your browser tab
you update by another tab or by the terminal
you save the UI

I bet you have a error

davidep · February 29, 2020, 5:56pm

In any case restarting the web server does not solve the issue because the old code is in the browser. A full page reload on the browser side is needed instead.

stephdl · February 29, 2020, 5:57pm

if cockpit is restarted, you have to log again in the remote browser page… I do it several time by day when I code ???

to be clear I mean

systemctl restart cockpit

davidep · February 29, 2020, 5:59pm

Yes a cockpit restart closes the underlying web socket connection which in turn ends the session after a few seconds. But cockpit restart should never happen.

stephdl · February 29, 2020, 6:00pm

except for this

davidep · February 29, 2020, 6:05pm

You usually update with Applications: when you go back to System the new page should be returned…