Nethserver-sssd-remove-provider : accentuated characters not correctly handled

pagaille (Matthieu Gaillet) 2017-11-13 12:17:59 UTC #1

NS 7.4 final
Hi,

nethserver-sssd-remove-provider doesn’t handle the accentuated characters correctly when creating users.tsv and groups.tsv.

The file’s charset is unknown,

file -i users.tsv 
users.tsv: text/plain; charset=unknown-8bit

Actually the contents looks like a mixup of Latin1 and UTF-8. Please try with names containing apostrophes ( ’ ) and accents ( é è ç, …)

The apostrophe looks coded as UTF-8, while the accentuated chars are in latin1. See screenshots.

Txs

giacomo (Giacomo Sanchietti) 2017-11-13 14:02:09 UTC #2

This is the script which does the job:

github.com

NethServer/nethserver-sssd/blob/master/root/etc/e-smith/events/actions/nethserver-sssd-export-accounts

#!/usr/bin/perl

#
# Copyright (C) 2017 Nethesis S.r.l.
# http://www.nethesis.it - nethserver@nethesis.it
#
# This script is part of NethServer.
#
# NethServer is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License,
# or any later version.
#
# NethServer is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with NethServer.  If not, see COPYING.

This file has been truncated. show original

Anyone want to try to hack it?

pagaille (Matthieu Gaillet) 2017-11-13 20:00:19 UTC #3

Clap your hands for pagaille’s first splash into the perl world

giacomo (Giacomo Sanchietti) 2017-11-14 08:21:59 UTC #4

Excellent work!!

Thank you pagaille!

davidep (Davide Principi) 2017-12-05 10:47:17 UTC #5

In nethserver-testing:

yum install http://packages.nethserver.org/nethserver/7.4.1708/testing/x86_64/Packages/nethserver-sssd-1.3.3-1.3.gfbbf95a.ns7.noarch.rpm

pagaille (Matthieu Gaillet) 2017-12-05 13:59:20 UTC #6

I tested the patch (manually applied) on two different systems recently and didn’t noticed any problem.

alefattorini (Alessio Fattorini) 2018-01-03 14:47:17 UTC #7

Can I close that? Ehi @pagaille sorry for coming late to the party. Great shoot!

pagaille (Matthieu Gaillet) 2018-01-03 15:22:41 UTC #8

Yes you can ! It is solved and merged. Txs

alefattorini (Alessio Fattorini) 2018-01-03 17:55:02 UTC #9