NethSecurity 8.8.0 Beta2 ready for testing!

Could you share the commit Beta2 is based on? (or even better tag it?)

Because the ns-storage package is stubborn in my effort to port Nethsecurity to arm64 I scrutinized this package. Now I take the opportunity to report issues that look odd to me. :thinking:

As mentioned before the ns.ha has the same bug as found in ns-storgage. The call to get path to the dhcp-leasefile in get_dhcp_leasefile has one argument to much
(second " dhcp"):

This below does not determine whether the os_device is found; even if grep exits non zero as the mount point /boot is not found; piping that result through uniq and awk exits zero as long uniq and awk are found in the (subprocess) path.
Please note it would be very beneficiary for the arm port effort if Nethsecurity looks for the partition mounted on /rom instead of /boot to determine the block device on which re OS lives.

It is not possible to setup the permanent storage on a second nvme (or a SD-card) because their partition naming schemes are different form traditional block devices. The partition numbers have a p prefix. Here the offending line that assumes the newly created partition is called {device}1 on nvme’s, emmc 's and SD-cards it is {device}p1.

Please note it would be very beneficiary for the arm port effort if Nethsecurity did not make assumptions on the partition naming scheme, possible like this:

While testing my solution for the partition naming scheme on X86_64 I removed and (re)created the permanent storage on different devices such as the nvme the OS lives on, a second nvme and a usb-drive.
Even though all is working well, I observed at some point the wrong partition was shown in the UI. I have not figured out why but have an strong hunch: If the permanent storage is removed the partition keeps the label ns_data. So while testing I ended up with 3 partitions labelled ns_data

root@NethSec:~# lsblk -o name,mountpoint,label,size,uuid
NAME          MOUNTPOINT LABEL         SIZE UUID
loop0         /overlay   rootfs_data 226.8M b6bcca32-4019-4154-94d8-2db91d6912b2
sda                                   59.5G
└─sda1                   ns_data      59.5G ecdc7c62-d821-4004-b458-cac8ed4002ce
nvme0n1                              465.8G
├─nvme0n1p1   /boot      kernel         16M 1234-ABCD
├─nvme0n1p2   /rom                     300M
├─nvme0n1p128                          239K
└─nvme0n1p3   /mnt/data  ns_data     465.4G 051b1224-5101-43df-8a56-9b25accd3c3a
nvme1n1                              931.5G
└─nvme1n1p1              ns_data     931.5G cd71df60-e662-4d25-b561-3baa735a07c7

Note nvme0n1p3 is mounted on /mnt/data not nvme1n1p1