Incorrect backup time reported when > 24 hours

danb35 · August 5, 2018, 11:57am

NethServer Version: 7.5
Module: Backup data

I’ve noticed something odd in my system. I have the backup data module installed, running a full backup weekly to my FreeNAS box and incrementals throughout the week. The full backup typically takes over 24 hours. But when it finishes, I get this email:

===== Report for data backup =====

Backup started at 2018-07-29 01:00:04
Pre backup scripts status: SUCCESS
Post backup scripts status: SUCCESS
Backup status: SUCCESS
Backup ended at 2018-07-30 06:09:30
Time elapsed: 5 hours, 9 minutes, 26 seconds

Seems whatever script is writing the report doesn’t account for the chance of a backup taking longer than 24 hours.

dnutan · August 5, 2018, 12:07pm

Here’s the script:

github.com

NethServer/nethserver-backup-data/blob/master/root/sbin/e-smith/backup-data#L114


    error("Event post-backup-data: FAIL");
}
out("Post backup scripts status: SUCCESS");
} else {
out("Post backup scripts status: SKIPPED (concurrent backup is running)");
}


out("Backup status: SUCCESS");
out("Backup ended at %s", strftime('%F %T',localtime));
my $duration = time - $start;
out("Time elapsed: %s hours, %s minutes, %s seconds", ($duration/(60*60))%24, ($duration/60)%60, $duration%60);


if ($name eq '') {
# disk usage stats
if ( open(FILE, "<$duLogFile") ) {
    %du = %{decode_json(join('', <FILE>))};
    close(FILE);
    if ($du{'size'}) { $du{'size'} = format_bytes($du{'size'}*1024); }
    if ($du{'used'}) { $du{'used'} = format_bytes($du{'used'}*1024); }
    if ($du{'avail'}) { $du{'avail'} = format_bytes($du{'avail'}*1024); }
    if ($du{'pcent'}) { $du{'pcent'} .= '%'; }

danb35 · August 5, 2018, 12:23pm

Seems like the easy answer would be to remove the %24 for the hours count. Otherwise, add a days counter that would probably be 0 for most folks, which would be only very slightly less easy. But modulo 24 on the hours without a days counter doesn’t make much sense to me.

dnutan · August 5, 2018, 12:47pm

You’re right. First option seems enough (no need for days). Would you like to do a PR on github?

danb35 · August 5, 2018, 6:32pm

Done, #23.

giacomo · August 6, 2018, 7:02am

Merged!

alefattorini · August 6, 2018, 3:09pm

Happy to see PRs growing into our community thanks @dnutan and @danb35