Cockpit UI - Web Proxy: unvalidated fields

[dnutan (Marc)]

On the Web Proxy & Filter application, Parent proxy, safe ports and proxy port fields have no format validation.

[giacomo (Giacomo Sanchietti)]

I know that @mamengoni is working on it, stay tuned

[mamengoni (Matteo Mengoni)]

you’re right, confirmed bug:

Issue: Cockpit: missing validators on proxy web panel

[edoardo_spadoni]

The bug is fixed and issue is verified: https://github.com/NethServer/dev/issues/5885

[dnutan (Marc)]

Thanks for the fix.
I don’t know if I messed up my test machine, but with the fixed package the Proxy port field cannot be left empty (default) anymore.

I’ve a doubt about Parent proxy. When using a hostname, it has to be a FQDN or it can also be a short hostname or “computer name” (like localhost, myupstreamproxy …)?
When using an IP it allowed to set a network address, broadcast address and 0.0.0.0 (I know an admin wouldn’t use those, but just thought of it to push the validators, not trying to be a PITA).

[edoardo_spadoni]

@dnutan

I don’t know if I messed up my test machine, but with the fixed package the Proxy port field cannot be left empty (default) anymore.

Yes, there was a missing condition. Fixed.

@dnutan

I’ve a doubt about Parent proxy . When using a hostname, it has to be a FQDN or it can also be a short hostname or “computer name” (like localhost, myupstreamproxy …)?
When using an IP it allowed to set a network address, broadcast address and 0.0.0.0 (I know an admin wouldn’t use those, but just thought of it to push the validators, not trying to be a PITA).

At the moment the validation is Validate::HOSTADDRESS, like in NethGUI. We can discuss to change it