Add more characters with Nethserver::password

stephdl · September 26, 2016, 8:29pm

With Nethserver::password you cannot set the number of characters of your password. I need more than 16 characters

The developer should be able to decide how much long must be his password.

davidep · September 26, 2016, 8:47pm

Hi @stephdl, there is plenty of options in the object constructor, length included

NethServer/nethserver-lib/blob/52623be1145e5ca50c587376468e6bb8730c2d53/lib/perl/NethServer/Password.pm#L50


my $class = shift;
my $fileName = shift;
my $opts = shift;


my $self = {
	'fileName' => $fileName,
	'defaultDir' => '/var/lib/nethserver/secrets',
	'dirty' => 1,
	'secret' => undef,
	'symbols' => ['A'..'Z', 'a'..'z', '0'..'9', '_'],
	'length' => 16,
	'autoSave' => $fileName ? 1 : 0,
};


for (qw(defaultDir symbols length autoSave)) {
	if(defined $opts->{$_}) {
	    $self->{$_} = $opts->{$_};
	}	
}


# Prepend defaultDir if fileName is not an absolute path

stephdl · September 26, 2016, 8:53pm

yep but nothing to use it with something like that

my $password = NethServer::Password::store(‘mysql’,‘length’=>‘64’);

Or I can go to sleep

davidep · September 26, 2016, 8:58pm

Grab this line

github.com

NethServer/nethserver-lib/blob/52623be1145e5ca50c587376468e6bb8730c2d53/lib/perl/NethServer/Password.pm#L153


}


=head2 store


Static shortcut method, compatible with esmith::util::genRandomPassword()


=cut
sub store
{
my $fileName = shift;
return NethServer::Password->new($fileName)->save()->getAscii()
}


1;

And add the second argument for new()

new('mysql', { length => 24 })

stephdl · September 26, 2016, 9:02pm

perldoc

davidep · September 26, 2016, 9:03pm

I gladly accept Pull Requests tonight

stephdl · September 26, 2016, 9:05pm

Ok, I will test it firstly, I will have other questions later about users authentication. With the two authentication methods I have a bit lost my Latin language.

stephdl · September 26, 2016, 9:15pm

Even When I reset the password by removing the older in /var/lib/nethserver/secrets/blowfishsecret I have all the time a new password set to 16 characters

Odd ?

davidep · September 26, 2016, 9:23pm

I cannot check it now, please be patient

Could you share a code snippet?

stephdl · September 26, 2016, 9:29pm

if (("$multiaccess" eq "enabled"))
  {
  $OUT .="\$cfg['Servers'][\$i]['auth_type'] = 'cookie';\n";
    my $blowfishsecret = NethServer::Password::store('blowfishsecret', { 'length' => 128 } ) || die('Could not generate blowfishsecret!');
    $OUT .="\$cfg['blowfish_secret'] = '$blowfishsecret';\n";
  }

See you tomorrow

davidep · September 26, 2016, 9:30pm

As said above, use new() not store()

NethServer::Password->new( 'blowfishsecret', { 'length' => 64 }) ->save()->getAscii()

stephdl · September 26, 2016, 9:43pm

Yep it works, something more simple could be welcome, or at least a perldoc complete page

Merci en tout cas (Thank a lot)

giacomo · September 27, 2016, 7:48am

Agree! That call seems voodoo to me …

davidep · September 27, 2016, 8:00am

Mate, don’t you appreciate self-documenting method chaining?

stephdl · September 27, 2016, 4:23pm

a bit of perldoc done