Nethserver-network-diag

[giacomo (Giacomo Sanchietti)]

@stephdl

add translations, need to understand how it works

Do you need help on this? If you want, I can try to add it.

@stephdl

ask to be integrated to the core

I back this! When you feel the package is almost ready, ping me and we will do a bit of review.

[stephdl (Stéphane de Labrusse)]

@giacomo

add translations, need to understand how it works

Do you need help on this? If you want, I can try to add it.

thank, yes you could do it please, but what we need also is a full stated documentation in the developer guide on how to implement it, it will help others.

@giacomo

I back this! When you feel the package is almost ready, ping me and we will do a bit of review.

let’s other break it, please go ahead.

[giacomo (Giacomo Sanchietti)]

I tested the new release, always better!

@stephdl

thank, yes you could do it please, but what we need also is a full stated documentation in the developer guide on how to implement it, it will help others.

The doc is already here:
http://docs.nethserver.org/projects/nethserver-devel/en/v7rc/i18n.html

Try to follow the steps for Transifex. It will fail on the push command if you don’t have the rights to add strings to the project.
When the packages is accepted in the core, I will take care of pushing to Transifex.

In the meanwhile, if you want to test a translation (Italian for example), just copy the English file here: /usr/share/nethesis/NethServer/Language/it/NethServer_Module_DiagTools.php.
Then edit the file and you’re done.

Let me know if I’m missing something on this part.

Last, I did a little review of the code, I just have two notes:

• you don’t need to execute external programs using sudo (like this: https://github.com/stephdl/nethserver-diagtools/blob/ns7/root/usr/share/nethesis/NethServer/Module/DiagTools/IpRoute.php#L18 ), simply remove the sudo call
• if the user doesn’t have nethserver-mail-server installed, you could parse the root mailbox (/var/spool/mail/root) using this class Manual :: Class to read mbox mail files.

[stephdl (Stéphane de Labrusse)]

@giacomo

you don’t need to execute external programs using sudo (like this: https://github.com/stephdl/nethserver-diagtools/blob/ns7/root/usr/share/nethesis/NethServer/Module/DiagTools/IpRoute.php#L18 ), simply remove the sudo call

yes, I didn’t tried it, I started with the traceroute command and it is funny because it is the only command which needs the sudo right …

thank’s for the tip.

[stephdl (Stéphane de Labrusse)]

@giacomo

Try to follow the steps for Transifex. It will fail on the push command if you don’t have the rights to add strings to the project.When the packages is accepted in the core, I will take care of pushing to Transifex.

should be ok and released in github

• .tx\config created

• transifex client installed

• push command failed as expected

  $ tx push -s
  NoSectionError: No section: ‘main’

Just for my concern, how trade with translations of modules, does a nethforge area exists in transifex with delegated rights, I could be interested to translate all my modules, for now I just offer the english version.

@giacomo

you don’t need to execute external programs using sudo

corrected, only traceroute uses sudo now

@giacomo

if the user doesn’t have nethserver-mail-server installed, you could parse the root mailbox (/var/spool/mail/root) using this class Manual :: Class to read mbox mail files.

sure, but it is not easy to retrieve it, and it also could be not be right if the email-server is installed.

[ssabbath (Walter Ferry Dissmann)]

Perfect…

You just read my mind.

[stephdl (Stéphane de Labrusse)]

yum install http://mirror.de-labrusse.fr/NethDev/nethserver-diagtools-0.0.1/nethserver-diagtools-0.0.5-1.ns7.sdl.noarch.rpm

[flatspin (Ralf Jeckel)]

Wow…

I was only some days on holidays and in the same time you were dooing this great innovation!
Thanks a lot. Great work, man!
PS: Installed latest version. Everything works perfect.

[giacomo (Giacomo Sanchietti)]

@stephdl

Just for my concern, how trade with translations of modules, does a nethforge area exists in transifex with delegated rights, I could be interested to translate all my modules, for now I just offer the english version.

For now there is only one project, but of course we can create a new one with delegated rights.
Since Transifex rely on git to check if a project is Open Source or not, before creating the project we should choose how to distribute the new translations.
Would you prefer a new nethserver-nethforge-lang- rpm? Or is better to include anything inside the main language package? (/cc @dev_team).

[dz00te]

back to work (sorry for late reply), and tested latest version… really great work and useful
i think one beer for you at fosdem for this, will not be enough… thank you!

[davidep (Davide Principi)]

@giacomo

Would you prefer a new nethserver-nethforge-lang- rpm? Or is better to include anything inside the main language package?

We already have everything in the main package. I’d prefer to keep everything in a single place and delegate permissions to members of @translations_team. Modules come from core to forge and vice-versa!

[stephdl (Stéphane de Labrusse)]

@davidep

We already have everything in the main package. I’d prefer to keep everything in a single place and delegate permissions to members of @translations_team. Modules come from core to forge and vice-versa!

that’s said , would it be imaginable for my transifex’s account to be granted for creating files to be translated by the community ?

where to ask ?

[stephdl (Stéphane de Labrusse)]

@davidep @giacomo do you think I need to add modifications or bug corrections on nethserver-diagtools…For example the sendmail tab could be a tab in nethserver-smarthost, all related email stuff will be in one place.

[davidep (Davide Principi)]

@stephdl

where to ask ?

You already asked in the right place

Let me see what Transifex can do for us!

@stephdl

all related email stuff will be in one place.

I’d rather prefer a Diagnostic category or the solution you already implemented: a Diagnostic tools entry under Status category…

I wouldn’t mix configuration and diagnostic tools!

[alefattorini (Alessio Fattorini)]

Looks very promising, I do want it on my servers

[stephdl (Stéphane de Labrusse)]

yep, it needs before translations @translations_team

[alefattorini (Alessio Fattorini)]

@translations_team
Steph needs your help here ping @jgjimenezs

[giacomo (Giacomo Sanchietti)]

We can release the rpm even without translations since languages are shipped in a different rpm

[stephdl (Stéphane de Labrusse)]

yum install http://mirror.de-labrusse.fr/NethDev/nethserver-diagtools-0.0.1/nethserver-diagtools-0.0.6-1.ns7.sdl.noarch.rpm

with this version you can scan each green interfaces with arp-scan