Roundcube: No managed interface in Nethgui/Cockpit

Neustradamus · November 24, 2019, 4:40am

For Roundcube, no managed interface in Nethgui and Cockpit, no settings and no possibility to enable or disable…

dnutan · November 24, 2019, 11:34am

Moved your request from #bug to #feature.
What Rouncube settings do you find we could benefit from having them on the server-manager?

Neustradamus · November 24, 2019, 4:32pm

In first, enable or disable the module.
In nethgui, it is done already done for:

ejabberd
Fail2ban
Mattermost
SOGo

In Cockpit, it is done already done for:

ejabberd
Fail2ban
Mattermost

SOGo is missing in Cockpit -> Applications:

https://github.com/NethServer/dev/issues/5920

stephdl · November 24, 2019, 6:09pm

it is about 13 thousand lines of code needed, only to enable or disable roundcube, does it sounds really essential

The developer team is good, with a huge willingness but his time is limited

Neustradamus · November 24, 2019, 6:33pm

For admins/users of a nice server, yes

stephdl · November 24, 2019, 6:39pm

Then the work could start by a PR on

github.com

NethServer/nethserver-roundcubemail/blob/master/root/etc/e-smith/templates/etc/httpd/conf.d/roundcubemail.conf/10base

#
# Round Cube Webmail is a browser-based multilingual IMAP client
# 

Alias /roundcubemail /usr/share/roundcubemail
Alias /webmail /usr/share/roundcubemail

<Directory /usr/share/roundcubemail/>
    Require { $roundcubemail{access} eq "public" ? "all granted" : "ip $localAccess" }
</Directory>

# Define who can access the installer
# keep this secured once configured

<Directory /usr/share/roundcubemail/installer/>
    Require local
</Directory>

# Those directories should not be viewed by Web clients.
<Directory /usr/share/roundcubemail/bin/>

This file has been truncated. show original

the status prop is not implemented, this is an example how it can be implemented

github.com

NethServer/nethserver-sogo/blob/master/root/etc/e-smith/templates/etc/httpd/conf.d/zzz_SOGo.conf/10base#L9


{
    my $sogo_host = ($sogod{'VirtualHost'} || 'Default');
    my $sogo_cert = ($sogod{'Certificate'} || '');
    my $lib = 'lib64';
	if (! -e '/usr/lib64/GNUstep/SOGo/') {
	    $lib = 'lib';
	}
	my $end_config = ' ';
    if (! (($sogod{'status'} || '') eq 'enabled')) {
	$OUT .= "#SOGo is disabled\n";
    }
    else{
        if ($sogo_host ne 'Default'){
            my $chain_file = ' ';
            $end_config = '</VirtualHost>';
            if ($sogo_cert =~ /\./) {
                $sogo_cert = (split(/\./, $sogo_cert))[0];
             }
            if ( -e "/etc/pki/tls/certs/$sogo_cert.crt") {

the default status prop must be created also in

after that the roundcubemail could be set to disabled.

danb35 · November 24, 2019, 8:04pm

…and of these, only Mattermost is a web application (and IMO, the enable/disable setting is redundant). Once again: what benefit is there to disabling an installed web application?

Neustradamus · November 24, 2019, 8:09pm

Example, disable for:

Some tests by the administator
Security problem
A temporary request from the CTO, CIO, …
…

danb35 · November 24, 2019, 8:20pm

…and how does simply uninstalling the application not accomplish the desired result?

Neustradamus · November 24, 2019, 9:26pm

Why we need to uninstall some applications if we must to install it again?

stephdl · November 24, 2019, 9:45pm

In that specific case a status prop is welcome to disable roundcubemail in the apache configuration

Neustradamus · November 25, 2019, 4:51am

Yes for this specific PHP app, it can be a desactivation in the webserver.

I have seen that there are 2 possibilities of links, by defaut it must be only one “webmail” not “webmail” + “roundcubemail”.
Maybe we can have user possibility to choice manual link (https://domain.tld/XXXX and https://XXX.domain.tld/ in the configuration page (nethgui + cockpit).

It can be possible to have with this same base for phpMyAdmin…

stephdl · November 25, 2019, 2:15pm

talk is cheap, I am waiting PR now

please detail what you are willing to do, we could valid what and not what to do and the best approach

Neustradamus · November 25, 2019, 3:21pm

1/ Minimum default settings page in Nethgui and Cockpit:

Enable/Disable the app
Choice the link: https://domain.tld/XXXX and have the possibility to have https://xxx.domain.tld/XXXX (domain.tld can be the main domain or other domain).

This is not only for Roundcube, phpMyAdmin, all other PHP apps…

Do not forget that if the app has a link, this link must be in Applications part of Netgui and Cockpit.
In Cockpit, for Nextcloud: there is a link to the software and “Settings” page

You can change in the same time:

Webmail | Provides Webmail with RoundcubeMail for NethServer
->
Roundcube | Provides Webmail
or
Roundcube | Provides Roundcube Webmail

stephdl · November 25, 2019, 3:24pm

agreed, first this should be done manually by a prop, not sure the panel is needed now

this could lead to issue with fail2ban, not sure it is good, the path is watched by fail2ban

Neustradamus · November 25, 2019, 3:55pm

How it is done currently with?

Mattermost
Nextcloud

stephdl · November 25, 2019, 4:30pm

mattermost there is no jail IIRC
for nextcloud you can check https://github.com/NethServer/nethserver-fail2ban/blob/master/root/etc/fail2ban/filter.d/nextcloud-auth.conf

but this is my example, check the jail of phpmyadmin, we look after the path https://github.com/NethServer/nethserver-fail2ban/blob/master/root/etc/fail2ban/filter.d/phpmyadmin.conf

Obviously maybe we could adapt it of course, but it is time, tests and so long

Neustradamus · November 26, 2019, 2:17am

My message was about it works with Mattermost and Nextcloud, so it is possible for other apps too